Remove electrical_components.Fuse from frequenz.api.common.v1alpha8
#394
+5
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
tiyash-basu-frequenz
force-pushed
the
390_remove_fuse
branch
from
a048695 to
e173516
Compare
Contributor
Author
tiyash-basu-frequenz
force-pushed
the
390_remove_fuse
branch
from
e173516 to
07a9f0f
Compare
Signed-off-by: Tiyash Basu <[email protected]>
tiyash-basu-frequenz
force-pushed
the
390_remove_fuse
branch
from
07a9f0f to
fc4a374
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the Fuse component from the v1alpha8 protobuf definitions and reflects that change in the release notes.
- Deleted the
Fusemessage and its oneof entry inelectrical_components.proto. - Renumbered the remaining oneof fields for grid connection, inverter, and voltage transformer.
- Updated
RELEASE_NOTES.mdto note removal ofelectrical_components.Fuse.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| proto/frequenz/api/common/v1alpha8/microgrid/electrical_components/electrical_components.proto | Removed Fuse message and updated oneof tag assignments for downstream components. |
| RELEASE_NOTES.md | Noted removal of electrical_components.Fuse in the v1alpha8 release notes. |
Comments suppressed due to low confidence (2)
RELEASE_NOTES.md:13
- [nitpick] The removal of
electrical_components.Fuseis a breaking change. Consider adding a 'Breaking Changes' section in the release notes to clearly inform API consumers about backward-incompatibility.
- A new package `frequenz.api.common.v1alpha8` has been added. It has the following changes when compared to `frequenz.api.common.v1alpha7`:
proto/frequenz/api/common/v1alpha8/microgrid/electrical_components/electrical_components.proto:581
- Reusing the tag numbers after removing the Fuse entry can break backward compatibility in protobuf. It’s better to reserve the old tag numbers (3–6) for the removed fields and keep existing fields at their original tags.
GridConnectionPoint grid_connection_point = 3;
llucax
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #390